[PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

[Peter Geis]

On Sun, May 8, 2022 at 9:40 AM Piotr Oniszczuk
<piotr.oniszczuk at gmail.com> wrote:
>
>
>
> > Wiadomość napisana przez Sascha Hauer <s.hauer at pengutronix.de> w dniu 22.04.2022, o godz. 09:28:
> >
> > From: Michael Riesch <michael.riesch at wolfvision.net>
> >
> > Enable the RK356x Video Output Processor (VOP) 2 on the Radxa
> > ROCK3 Model A.
> >
> > Signed-off-by: Michael Riesch <michael.riesch at wolfvision.net>
> > Reported-by: kernel test robot <lkp at intel.com>
> > Link: https://lore.kernel.org/r/20220310210352.451136-4-michael.riesch@wolfvision.net
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > ---
>
> Sascha, Michael,

Good Afternoon,
>
> I'm using v11 series on 5.18-rc5 on rk3566 tvbox with great success.
> Recently i started to work on rock3-a (rk3568).
> v11 gives me video, audio - but cec is not working on rock3-a.
>
> I was told:
>
> 32k clock needed for cec and this clock is generated by the rtc which is embedded in the rk8xx regulator.
> So you should make sure it is enabled when hdmi is powerd on, eg adding it to the RK3568_PD_VO powerdomain should help
>
> I was trying to do this in dts https://pastebin.com/67wu9QrH but cec is still non-functional
>
> Maybe You have some hints/pointers here?

Add the following to the HDMI node:
assigned-clocks = <&cru CLK_HDMI_CEC>;
assigned-clock-rates = <32768>;

The issue is the clk_rtc32k_frac clock that feeds clk_rtc_32k which
feeds clk_hdmi_cec is 24mhz at boot, which is too high for CEC to
function.
I submitted a patch to have the hdmi driver handle this, but it broke
other SoCs because 32k is an optional clock.
Since this is the case, I'd like Robin to weigh in on going the
assigned-clock route again.

>
> br
>
> btw: my dts gives me working usb2 port0/port1 and usb3 port0. but usb3 port1 is non-working
> maybe you know what is missing?

You're missing &usb2phy0_otg.

Very Respectfully,
Peter Geis