[PATCH] clk: bcm2835: fix bcm2835_clock_choose_div

Maxime Ripard maxime at cerno.tech
Tue May 3 07:58:04 PDT 2022


Hi,

On Thu, Apr 28, 2022 at 08:30:10PM +0200, Stefan Wahren wrote:
> The commit 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
> accidentially breaks the behavior of bcm2835_clock_choose_div() and
> booting of Raspberry Pi. The removed do_div macro call had side effects,
> so we need to restore it.
> 
> Fixes: 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
> Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>

I only found this patch after debugging why the HDMI driver was
returning -EINVAL at probe on -rc5.

Acked-by: Maxime Ripard <maxime at cerno.tech>
Tested-by: Maxime Ripard <maxime at cerno.tech>

Thanks!
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20220503/d80597bc/attachment.sig>


More information about the linux-arm-kernel mailing list