[xilinx-xlnx:xlnx_rebase_v5.15_LTS 225/1039] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:3050 axienet_probe() warn: missing error code 'ret'
Dan Carpenter
dan.carpenter at oracle.com
Tue Mar 29 03:16:37 PDT 2022
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head: ea33365bd1a8cf667a122498e8f551df05609f92
commit: ee94241b2118ddd38a456b2b805fc584b57de58f [225/1039] net: axienet: added multichannel DMA support
config: x86_64-randconfig-m001-20220328 (https://download.01.org/0day-ci/archive/20220329/202203291706.pCeTZakA-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
New smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:3050 axienet_probe() warn: missing error code 'ret'
Old smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:204 axienet_dma_bd_init() error: uninitialized symbol 'ret'.
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:3110 axienet_probe() warn: inconsistent indenting
vim +/ret +3050 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
bf05571deda79b Appana Durga Kedareswara Rao 2020-01-24 3031
bf05571deda79b Appana Durga Kedareswara Rao 2020-01-24 3032 of_node_put(np);
bf05571deda79b Appana Durga Kedareswara Rao 2020-01-24 3033 #endif
ee94241b2118dd Saurabh Sengar 2021-01-22 3034 if (!slave) {
ee94241b2118dd Saurabh Sengar 2021-01-22 3035 #ifdef CONFIG_AXIENET_HAS_MCDMA
ee94241b2118dd Saurabh Sengar 2021-01-22 3036 ret = axienet_mcdma_probe(pdev, lp, ndev);
ee94241b2118dd Saurabh Sengar 2021-01-22 3037 #else
ee94241b2118dd Saurabh Sengar 2021-01-22 3038 ret = axienet_dma_probe(pdev, ndev);
ee94241b2118dd Saurabh Sengar 2021-01-22 3039 #endif
46aa27df885321 Srikanth Thokala 2015-05-05 3040 if (ret) {
ee94241b2118dd Saurabh Sengar 2021-01-22 3041 pr_err("Getting DMA resource failed\n");
ee94241b2118dd Saurabh Sengar 2021-01-22 3042 goto free_netdev;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3043 }
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3044
ee94241b2118dd Saurabh Sengar 2021-01-22 3045 if (dma_set_mask_and_coherent(lp->dev, DMA_BIT_MASK(lp->dma_mask)) != 0) {
ee94241b2118dd Saurabh Sengar 2021-01-22 3046 dev_warn(&pdev->dev, "default to %d-bit dma mask\n", XAE_DMA_MASK_MIN);
ee94241b2118dd Saurabh Sengar 2021-01-22 3047 if (dma_set_mask_and_coherent(lp->dev,
ee94241b2118dd Saurabh Sengar 2021-01-22 3048 DMA_BIT_MASK(XAE_DMA_MASK_MIN)) != 0) {
ee94241b2118dd Saurabh Sengar 2021-01-22 3049 dev_err(&pdev->dev, "dma_set_mask_and_coherent failed, aborting\n");
ee94241b2118dd Saurabh Sengar 2021-01-22 @3050 goto free_netdev;
ret = dma_set_mask_and_coherent().
f735c40ed93cca Andre Przywara 2020-03-24 3051 }
5fff0151b3244d Andre Przywara 2020-03-24 3052 }
5fff0151b3244d Andre Przywara 2020-03-24 3053
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3054 ret = axienet_dma_clk_init(pdev);
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3055 if (ret) {
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3056 if (ret != -EPROBE_DEFER)
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3057 dev_err(&pdev->dev, "DMA clock init failed %d\n", ret);
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3058 goto free_netdev;
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3059 }
ee94241b2118dd Saurabh Sengar 2021-01-22 3060 }
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3061
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3062 ret = axienet_clk_init(pdev, &lp->aclk, &lp->eth_sclk,
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3063 &lp->eth_refclk, &lp->eth_dclk);
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3064 if (ret) {
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3065 if (ret != -EPROBE_DEFER)
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3066 dev_err(&pdev->dev, "Ethernet clock init failed %d\n", ret);
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3067 goto err_disable_clk;
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3068 }
353f7909290557 Appana Durga Kedareswara Rao 2021-01-22 3069
ee94241b2118dd Saurabh Sengar 2021-01-22 3070 lp->eth_irq = platform_get_irq(pdev, 0);
ee94241b2118dd Saurabh Sengar 2021-01-22 3071 /* Check for Ethernet core IRQ (optional) */
ee94241b2118dd Saurabh Sengar 2021-01-22 3072 if (lp->eth_irq <= 0)
ee94241b2118dd Saurabh Sengar 2021-01-22 3073 dev_info(&pdev->dev, "Ethernet core IRQ not defined\n");
ee94241b2118dd Saurabh Sengar 2021-01-22 3074
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3075 /* Retrieve the MAC address */
83216e3988cd19 Michael Walle 2021-04-12 3076 ret = of_get_mac_address(pdev->dev.of_node, mac_addr);
83216e3988cd19 Michael Walle 2021-04-12 3077 if (!ret) {
da90e38003e2f0 Tobias Klauser 2016-12-07 3078 axienet_set_mac_address(ndev, mac_addr);
83216e3988cd19 Michael Walle 2021-04-12 3079 } else {
83216e3988cd19 Michael Walle 2021-04-12 3080 dev_warn(&pdev->dev, "could not find MAC address property: %d\n",
83216e3988cd19 Michael Walle 2021-04-12 3081 ret);
83216e3988cd19 Michael Walle 2021-04-12 3082 axienet_set_mac_address(ndev, NULL);
83216e3988cd19 Michael Walle 2021-04-12 3083 }
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3084
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3085 lp->coalesce_count_rx = XAXIDMA_DFT_RX_THRESHOLD;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3086 lp->coalesce_count_tx = XAXIDMA_DFT_TX_THRESHOLD;
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3087
95219aa538e11d Srikanth Thokala 2015-05-05 3088 lp->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
46aa27df885321 Srikanth Thokala 2015-05-05 3089 if (lp->phy_node) {
09a0354cadec26 Robert Hancock 2019-06-06 3090 ret = axienet_mdio_setup(lp);
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3091 if (ret)
09a0354cadec26 Robert Hancock 2019-06-06 3092 dev_warn(&pdev->dev,
09a0354cadec26 Robert Hancock 2019-06-06 3093 "error registering MDIO bus: %d\n", ret);
46aa27df885321 Srikanth Thokala 2015-05-05 3094 }
1a02556086fc0e Robert Hancock 2020-10-28 3095 if (lp->phy_mode == PHY_INTERFACE_MODE_SGMII ||
1a02556086fc0e Robert Hancock 2020-10-28 3096 lp->phy_mode == PHY_INTERFACE_MODE_1000BASEX) {
1a02556086fc0e Robert Hancock 2020-10-28 3097 if (!lp->phy_node) {
1a02556086fc0e Robert Hancock 2020-10-28 3098 dev_err(&pdev->dev, "phy-handle required for 1000BaseX/SGMII\n");
1a02556086fc0e Robert Hancock 2020-10-28 3099 ret = -EINVAL;
59cd4f19267a0a Robert Hancock 2021-03-11 3100 goto cleanup_mdio;
1a02556086fc0e Robert Hancock 2020-10-28 3101 }
1a02556086fc0e Robert Hancock 2020-10-28 3102 lp->pcs_phy = of_mdio_find_device(lp->phy_node);
1a02556086fc0e Robert Hancock 2020-10-28 3103 if (!lp->pcs_phy) {
1a02556086fc0e Robert Hancock 2020-10-28 3104 ret = -EPROBE_DEFER;
59cd4f19267a0a Robert Hancock 2021-03-11 3105 goto cleanup_mdio;
1a02556086fc0e Robert Hancock 2020-10-28 3106 }
1a02556086fc0e Robert Hancock 2020-10-28 3107 lp->phylink_config.pcs_poll = true;
1a02556086fc0e Robert Hancock 2020-10-28 3108 }
8a3b7a252dca9f Daniel Borkmann 2012-01-19 3109
f5203a3d9b25fa Robert Hancock 2019-06-06 3110 lp->phylink_config.dev = &ndev->dev;
f5203a3d9b25fa Robert Hancock 2019-06-06 3111 lp->phylink_config.type = PHYLINK_NETDEV;
Pull this code in a tab.
f5203a3d9b25fa Robert Hancock 2019-06-06 3112
f5203a3d9b25fa Robert Hancock 2019-06-06 3113 lp->phylink = phylink_create(&lp->phylink_config, pdev->dev.fwnode,
f5203a3d9b25fa Robert Hancock 2019-06-06 3114 lp->phy_mode,
f5203a3d9b25fa Robert Hancock 2019-06-06 3115 &axienet_phylink_ops);
f5203a3d9b25fa Robert Hancock 2019-06-06 3116 if (IS_ERR(lp->phylink)) {
f5203a3d9b25fa Robert Hancock 2019-06-06 3117 ret = PTR_ERR(lp->phylink);
f5203a3d9b25fa Robert Hancock 2019-06-06 3118 dev_err(&pdev->dev, "phylink_create error (%i)\n", ret);
59cd4f19267a0a Robert Hancock 2021-03-11 3119 goto cleanup_mdio;
f5203a3d9b25fa Robert Hancock 2019-06-06 3120 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
More information about the linux-arm-kernel
mailing list