[PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths.

Jinlong Mao quic_jinlmao at quicinc.com
Thu Mar 24 07:23:19 PDT 2022


Hi Greg,

Thanks for your review.

On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote:
> On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote:
>> Use hash length of the source's device name to map to the pointer
>> of the enabled path. Using IDR will be more efficient than using
>> the list. And there could be other sources except STM and CPU etms
>> in the new HWs. It is better to maintain all the paths together.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao at quicinc.com>
>> ---
>>   drivers/hwtracing/coresight/coresight-core.c | 75 +++++++-------------
>>   1 file changed, 26 insertions(+), 49 deletions(-)
> Your subject line is odd.  Please put back the driver subsystem in the
> subject line so that it makes more sense.
I will update the subject in next version.
>
> And how have you measured "more efficient"?

Using IDR would be better than doing a sequential search as there will 
be much more device  in future.

>
> thanks,
>
> greg k-h

Thanks

Jinlong Mao




More information about the linux-arm-kernel mailing list