[PATCH v3] coresight: core: Fix coresight device probe failure issue

Jinlong Mao quic_jinlmao at quicinc.com
Tue Mar 15 01:52:58 PDT 2022


On 3/15/2022 4:42 PM, Suzuki K Poulose wrote:
> On 15/03/2022 08:36, Jinlong Mao wrote:
>> On 3/10/2022 5:10 PM, Suzuki K Poulose wrote:
>>> Hi Jinlong
>>>
>>>
>>> On 09/03/2022 14:22, Mao Jinlong wrote:
>>>> It is possibe that probe failure issue happens when the device
>>>> and its child_device's probe happens at the same time.
>>>> In coresight_make_links, has_conns_grp is true for parent, but
>>>> has_conns_grp is false for child device as has_conns_grp is set
>>>> to true in coresight_create_conns_sysfs_group. The probe of parent
>>>> device will fail at this condition. Add has_conns_grp check for
>>>> child device before make the links and make the process from
>>>> device_register to connection_create be atomic to avoid this
>>>> probe failure issue.
>>>>
>>>> Suggested-by: Suzuki K Poulose <suzuki.poulose at arm.com>
>>>> Suggested-by: Mike Leach <mike.leach at linaro.org>
>>>> Signed-off-by: Mao Jinlong <quic_jinlmao at quicinc.com>
>>>
>>> Thanks for the rework. The patch looks good to me.
>>>
>>> Suzuki
>> Thanks Suzuki.
>>
>> Hi Mathieu & Mike,
>>
>> Could you please help to review and provide your comments for the 
>> PATCH V3 ?
>
> Thats what I just said above. The patch looks good to me, I can queue
> this in the next cycle.

Thanks Suzuki.

Best Regards
Jinlong Mao
>
> Kind regards
> Suzuki
>
>>
>> Thanks
>> Jinlong Mao
>



More information about the linux-arm-kernel mailing list