[PATCH] mfd: Use platform_get_irq() to get the interrupt

Linus Walleij linus.walleij at linaro.org
Mon Mar 14 16:12:35 PDT 2022


On Wed, Mar 9, 2022 at 4:56 AM <cgel.zte at gmail.com> wrote:

> From: Minghao Chi (CGEL ZTE) <chi.minghao at zte.com.cn>
>
> It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
> for requesting IRQ's resources any more, as they can be not ready yet in
> case of DT-booting.
>
> platform_get_irq() instead is a recommended way for getting IRQ even if
> it was not retrieved earlier.
>
> It also makes code simpler because we're getting "int" value right away
> and no conversion from resource to int is required.
>
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao at zte.com.cn>

OK that is indeed much better code:
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list