[PATCH] irqchip/apple-aic: application of sizeof() to a pointer

Guo Zhengkui guozhengkui at vivo.com
Wed Mar 9 21:02:38 PST 2022


`ic->fiq_aff[fiq]` is a pointer to the unnamed struct.
`sizeof(ic->fiq_aff[fiq])` intends to get the size of this pointer. But
readers may get confused. `sizeof(unsigned long)` makes more sense because
`unsigned long` has the same size of pointer.

reference:
https://lore.kernel.org/all/Ya%2FeUbdN1+ABFVWf@rowland.harvard.edu/
https://lore.kernel.org/all/YbBGGI9wQenI4kP7@kroah.com/
https://lore.kernel.org/all/20211209062441.9856-1-guozhengkui@vivo.com/

Signed-off-by: Guo Zhengkui <guozhengkui at vivo.com>
---
 drivers/irqchip/irq-apple-aic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index b40199c6625e..23098b469b1a 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -810,7 +810,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff)
 	if (WARN_ON(n < 0))
 		return;
 
-	ic->fiq_aff[fiq] = kzalloc(sizeof(ic->fiq_aff[fiq]), GFP_KERNEL);
+	ic->fiq_aff[fiq] = kzalloc(sizeof(unsigned long), GFP_KERNEL);
 	if (!ic->fiq_aff[fiq])
 		return;
 
-- 
2.20.1




More information about the linux-arm-kernel mailing list