[PATCH v2 3/7] tty: serial: samsung: constify s3c24xx_serial_drv_data

Jiri Slaby jirislaby at kernel.org
Mon Mar 7 00:33:19 PST 2022


On 07. 03. 22, 9:09, Krzysztof Kozlowski wrote:
> The driver data (struct s3c24xx_serial_drv_data) is only used to
> initialize the driver properly and is not modified.  Make it const.
...
> @@ -2755,9 +2755,9 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
>   	},
>   	.fifosize = { 256, 64, 16, 16 },
>   };
> -#define S5PV210_SERIAL_DRV_DATA ((kernel_ulong_t)&s5pv210_serial_drv_data)
> +#define S5PV210_SERIAL_DRV_DATA (&s5pv210_serial_drv_data)
>   #else
> -#define S5PV210_SERIAL_DRV_DATA	(kernel_ulong_t)NULL
> +#define S5PV210_SERIAL_DRV_DATA	NULL

Yet, I still don't see why the switch from ulong->ptr happens in this 
"constify it" patch?

thanks,
-- 
-- 
js
suse labs



More information about the linux-arm-kernel mailing list