[PATCH v1 4/6] ARM: dts: lan966x: add flexcom SPI nodes

[Claudiu.Beznea at microchip.com]

On 03.03.2022 18:03, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Add all the SPI nodes for the flexcom IP block. Keep them
> disabled by default.
> 
> Signed-off-by: Michael Walle <michael at walle.cc>
> ---
>  arch/arm/boot/dts/lan966x.dtsi | 75 ++++++++++++++++++++++++++++++++++
>  1 file changed, 75 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index bea69b6d2749..0616927f1bb1 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -105,6 +105,21 @@ usart0: serial at 200 {
>                                 atmel,fifo-size = <32>;
>                                 status = "disabled";
>                         };
> +
> +                       spi0: spi at 400 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               compatible = "atmel,at91rm9200-spi";
> +                               reg = <0x400 0x200>;

try to keep the:
- compatible
- reg
first as all the other nodes in this DT. It would be simple to follow.

> +                               interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> +                               dmas = <&dma0 AT91_XDMAC_DT_PERID(3)>,
> +                                          <&dma0 AT91_XDMAC_DT_PERID(2)>;

Align dma entries. Same for the rest of nodes added.

> +                               dma-names = "tx", "rx";
> +                               clocks = <&nic_clk>;
> +                               clock-names = "spi_clk";
> +                               atmel,fifo-size = <32>;
> +                               status = "disabled";
> +                       };
>                 };
> 
>                 flx1: flexcom at e0044000 {
> @@ -128,6 +143,21 @@ usart1: serial at 200 {
>                                 atmel,fifo-size = <32>;
>                                 status = "disabled";
>                         };
> +
> +                       spi1: spi at 400 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               compatible = "atmel,at91rm9200-spi";
> +                               reg = <0x400 0x200>;
> +                               interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> +                               dmas = <&dma0 AT91_XDMAC_DT_PERID(5)>,
> +                                          <&dma0 AT91_XDMAC_DT_PERID(4)>;
> +                               dma-names = "tx", "rx";
> +                               clocks = <&nic_clk>;
> +                               clock-names = "spi_clk";
> +                               atmel,fifo-size = <32>;
> +                               status = "disabled";
> +                       };
>                 };
> 
>                 trng: rng at e0048000 {
> @@ -168,6 +198,21 @@ usart2: serial at 200 {
>                                 atmel,fifo-size = <32>;
>                                 status = "disabled";
>                         };
> +
> +                       spi2: spi at 400 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               compatible = "atmel,at91rm9200-spi";
> +                               reg = <0x400 0x200>;
> +                               interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
> +                               dmas = <&dma0 AT91_XDMAC_DT_PERID(7)>,
> +                                          <&dma0 AT91_XDMAC_DT_PERID(6)>;
> +                               dma-names = "tx", "rx";
> +                               clocks = <&nic_clk>;
> +                               clock-names = "spi_clk";
> +                               atmel,fifo-size = <32>;
> +                               status = "disabled";
> +                       };
>                 };
> 
>                 flx3: flexcom at e0064000 {
> @@ -191,6 +236,21 @@ usart3: serial at 200 {
>                                 atmel,fifo-size = <32>;
>                                 status = "disabled";
>                         };
> +
> +                       spi3: spi at 400 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               compatible = "atmel,at91rm9200-spi";
> +                               reg = <0x400 0x200>;
> +                               interrupts = <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
> +                               dmas = <&dma0 AT91_XDMAC_DT_PERID(9)>,
> +                                          <&dma0 AT91_XDMAC_DT_PERID(8)>;
> +                               dma-names = "tx", "rx";
> +                               clocks = <&nic_clk>;
> +                               clock-names = "spi_clk";
> +                               atmel,fifo-size = <32>;
> +                               status = "disabled";
> +                       };
>                 };
> 
>                 dma0: dma-controller at e0068000 {
> @@ -233,6 +293,21 @@ usart4: serial at 200 {
>                                 atmel,fifo-size = <32>;
>                                 status = "disabled";
>                         };
> +
> +                       spi4: spi at 400 {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               compatible = "atmel,at91rm9200-spi";
> +                               reg = <0x400 0x200>;
> +                               interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> +                               dmas = <&dma0 AT91_XDMAC_DT_PERID(11)>,
> +                                          <&dma0 AT91_XDMAC_DT_PERID(10)>;
> +                               dma-names = "tx", "rx";
> +                               clocks = <&nic_clk>;
> +                               clock-names = "spi_clk";
> +                               atmel,fifo-size = <32>;
> +                               status = "disabled";
> +                       };
>                 };
> 
>                 timer0: timer at e008c000 {
> --
> 2.30.2
>