[PATCH] kselftest/arm64: Log the PIDs of the parent and child in sve-ptrace

Shuah Khan skhan at linuxfoundation.org
Thu Mar 3 11:58:41 PST 2022


On 3/3/22 12:28 PM, Mark Brown wrote:
> If the test triggers a problem it may well result in a log message from
> the kernel such as a WARN() or BUG(). If these include a PID it can help
> with debugging to know if it was the parent or child process that triggered
> the issue, since the test is just creating a new thread the process name
> will be the same either way. Print the PIDs of the parent and child on
> startup so users have this information to hand should it be needed.
> 
> Signed-off-by: Mark Brown <broonie at kernel.org>
> ---
>   tools/testing/selftests/arm64/fp/sve-ptrace.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/arm64/fp/sve-ptrace.c b/tools/testing/selftests/arm64/fp/sve-ptrace.c
> index 4bd333768cc4..4c418b2021e0 100644
> --- a/tools/testing/selftests/arm64/fp/sve-ptrace.c
> +++ b/tools/testing/selftests/arm64/fp/sve-ptrace.c
> @@ -487,6 +487,8 @@ static int do_parent(pid_t child)
>   	unsigned int vq, vl;
>   	bool vl_supported;
>   
> +	ksft_print_msg("Parent is %d, child is %d\n", getpid(), child);
> +
>   	/* Attach to the child */
>   	while (1) {
>   		int sig;
> 

Nice addition. Thanks for the patch.

Reviewed-by: Shuah Khan <skhan at linuxfoundation.org>

thanks,
-- Shuah



More information about the linux-arm-kernel mailing list