[PATCH v3] arm64: Do not defer reserve_crashkernel() for platforms with no DMA memory zones

Vijay Balakrishna vijayb at linux.microsoft.com
Wed Mar 2 12:41:42 PST 2022


Thanks Pasha.

Catalin, Will,

I can generate a new version with suggested change from Pasha.  I'm fine 
if you modify.

Thanks,
Vijay


On 3/2/2022 10:15 AM, Pasha Tatashin wrote:
> Hi Vijay,
> 
> The patch looks good to me, just one nit below.
> 
>> -phys_addr_t arm64_dma_phys_limit __ro_after_init;
>> +#if IS_ENABLED(CONFIG_ZONE_DMA) || IS_ENABLED(CONFIG_ZONE_DMA32)
>> +phys_addr_t __ro_after_init arm64_dma_phys_limit;
>> +#else
>> +phys_addr_t __ro_after_init arm64_dma_phys_limit = PHYS_MASK + 1;
> 
> Since in this case arm64_dma_phys_limit is initialized during
> declaration, it would make sense to use const instead of
> __ro_after_init. Consider changing the above to this:
> const phys_addr_t arm64_dma_phys_limit = PHYS_MASK + 1;
> 
> Reviewed-by: Pasha Tatashin <pasha.tatashin at soleen.com>
> 
> Thank you,
> Pasha



More information about the linux-arm-kernel mailing list