[PATCH] misc: atmel-ssc: Handle error for clk_prepare

Jiasheng Jiang jiasheng at iscas.ac.cn
Wed Mar 2 00:49:02 PST 2022


As the potential failure of the clk_prepare(),
it should be better to check it and return error if fails.

Fixes: eb1f2930609b ("Driver for the Atmel on-chip SSC on AT32AP and AT91")
Signed-off-by: Jiasheng Jiang <jiasheng at iscas.ac.cn>
---
 drivers/misc/atmel-ssc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index d6cd5537126c..e0207e837e35 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -25,7 +25,7 @@ static LIST_HEAD(ssc_list);
 
 struct ssc_device *ssc_request(unsigned int ssc_num)
 {
-	int ssc_valid = 0;
+	int ssc_valid = 0, ret;
 	struct ssc_device *ssc;
 
 	mutex_lock(&user_lock);
@@ -57,7 +57,9 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
 	ssc->user++;
 	mutex_unlock(&user_lock);
 
-	clk_prepare(ssc->clk);
+	ret = clk_prepare(ssc->clk);
+	if (ret)
+		return ret;
 
 	return ssc;
 }
-- 
2.25.1




More information about the linux-arm-kernel mailing list