[PATCH] tty: serial: samsung_tty: loopback mode support

[Chanho Park]

> Subject: Re: [PATCH] tty: serial: samsung_tty: loopback mode support
> 
> On Mon, 27 Jun 2022, Chanho Park wrote:
> 
> > Internal loopback mode can be supported by setting
> > S3C2443_UCON_LOOPBACK bit. The mode & bit can be supported since
> > s3c2410 and later SoCs.
> 
> In that case, why is the  LOOPBACK define named 2443 and not 2410???

It might be copied from mach-s3c24xx.

> 
> The change looks fine otherwise.
> 
> I note though that many of the current drivers won't return TOICM_LOOP
> from ->get_mctrl() but I don't think it's exactly wrong to return it
> either. Perhaps lack of returning it is due to Documentation/driver-
> api/serial/driver.rst not including TOICM_LOOP in get_mctrl's list of
> information but only in set_mctrl's one.

According to the description, TIOCM_LOOP bit might be used only for setting.
I'll drop the bit manipulation from get_mctrl callback.
Thanks for the heads up.

Best Regards,
Chanho Park