[PATCH v2] soc: mediatek: Introduce mediatek-regulator-coupler driver

Dmitry Osipenko dmitry.osipenko at collabora.com
Tue Jun 28 04:49:06 PDT 2022


Hi Angelo,

On 6/28/22 14:01, AngeloGioacchino Del Regno wrote:
> +		mrc->vsram_rdev = rdev;
> +	} else if (!strstr(rdev_name, "vgpu") && !strstr(rdev_name, "Vgpu"))
> +		return 1;

Nit: checkpatch --strict should warn about the missing {} here. In
general braces are always needed for each condition if they were needed
once in the if-else.

Reviewed-by: Dmitry Osipenko <dmitry.osipenko at collabora.com>

-- 
Best regards,
Dmitry



More information about the linux-arm-kernel mailing list