[PATCH] spi: s3c64xx: move dma_release_channel to unprepare
Mark Brown
broonie at kernel.org
Tue Jun 28 03:31:30 PDT 2022
On Mon, 27 Jun 2022 10:38:45 +0900, Chanho Park wrote:
> This fixes the sequence of dma_release_channel.
> Since commit f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only
> during data transfer"),
> dma_release_channel has been located in the s3c64xx_spi_transfer_one
> but this makes invalid return of can_dma callback.
> __spi_unmap_msg will check whether the request is requested by dma or
> not via can_dma callback. When it is calling to check it, the channels
> will be already released at the end of s3c64xx_spi_transfer_one so the
> callback function will return always "false". So, they can't be unmapped
> from __spi_unmap_msg call. To fix this, we need to add
> unprepare_transfer_hardware callback and move the dma_release_channel
> from s3c64xx_spi_transfer_one to there.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: s3c64xx: move dma_release_channel to unprepare
commit: 82295bc0d192d7e35e0568b18ca66da2c3058fd5
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
More information about the linux-arm-kernel
mailing list