[PATCHv2 1/2] net: ethernet: stmmac: dwmac-rk: Add gmac support for rk3588

Sebastian Reichel sebastian.reichel at collabora.com
Tue Jun 28 03:01:52 PDT 2022


Hi Krzysztof,

On Tue, Jun 28, 2022 at 10:55:04AM +0200, Krzysztof Kozlowski wrote:
> On 27/06/2022 19:07, Sebastian Reichel wrote:
> > From: David Wu <david.wu at rock-chips.com>
> > 
> > Add constants and callback functions for the dwmac on RK3588 soc.
> > As can be seen, the base structure is the same, only registers
> > and the bits in them moved slightly.
> > 
> > Signed-off-by: David Wu <david.wu at rock-chips.com>
> > [rebase, squash fixes]
> > Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> > ---
> > Krzysztof asked what "php" means. The answer is: The datasheet
> > calls the referenced syscon area "PHP_GRF" with GRF meaning
> > "general register file". PHP is never written out in the datasheet,
> > but is the name of a subsystem in the SoC which contains the ethernet
> > controllers, USB and SATA with it's own MMU and power domain.
> 
> Maybe there was a typo and name is PPH? Like some kind of short cut of
> "peripheral"?

Maybe, but then it is consistent throughout the datasheet and the
vendor kernel. There is a few hundred instances of PHP_ in the
datasheet and PPH is only found for Displayport PHYs (DPPHY).

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20220628/f3a431e7/attachment.sig>


More information about the linux-arm-kernel mailing list