[PATCH] tty: serial: samsung_tty: support more than 4 uart ports

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Mon Jun 27 03:33:51 PDT 2022


On 27/06/2022 09:15, Chanho Park wrote:
> Regarding Exynos Auto v9 SoC, it supports uarts up to 12. However, the
> maximum number of the ports has been derived from
> CONFIG_SERIAL_SAMSUNG_UARTS and tightly coupled with the config for
> previous Samsung SoCs such as s3c24xx and s3c64xx. To overcome this
> limitation, this changes the usage of the definition to UART_NR which is
> widely used from other serial drivers. This also defines the value to 12
> only for ARM64 SoCs to not affect the change to previous arm32 SoCs.
> Instead of enumerating all the ports as predefined arrays, this
> introduces s3c24xx_serial_init_port_default that is initializing the
> structure as default value. 
> Regarding the ports which are greater than 4
> will be initialized as default value and the fifo size will be retrieved
> from the DT property.

You need to explain why you are doing this.

It's confusing to initialize some statically and some dynamically.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list