[PATCH] clk/meson: Hold reference returned by of_get_parent()

[Martin Blumenstingl]

Hello,

thank you for submitting this patch!

On Fri, Jun 24, 2022 at 12:28 PM Liang He <windhl at 126.com> wrote:
[...]
>  these bugs are compiled tested in 5.19rc2 with at91_dt_defconfig
Please note that you're changing some drivers which are only in the
arch/arm/configs/multi_v7_defconfig while others are only in
arch/arm64/configs/defconfig
I think at91_dt_defconfig will not compile any of the drivers below

[...]
> diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
> index 8f3b7a94a667..54188319f349 100644
> --- a/drivers/clk/meson/meson8b.c
> +++ b/drivers/clk/meson/meson8b.c
> @@ -3796,8 +3796,11 @@ static void __init meson8b_clkc_init_common(struct device_node *np,
>         struct clk *notifier_clk;
>         struct regmap *map;
>         int i, ret;
> +       struct device_node *tp;
This function uses reverse christmas tree sorting, so the longest line
goes on top while the shortest should stay on the bottom.
Can you please explain what "tp" stands for? Personally I would call
this variable parent_np, but maybe "tp" has a similar meaning.


Best regards,
Martin