[xilinx-xlnx:xlnx_rebase_v5.15_LTS 643/1197] drivers/gpu/drm/xlnx/xlnx_scaler.c:1394:21: warning: variable 'fmt_out' set but not used

[kernel test robot]

Hi Venkateshwar,

FYI, the error/warning still remains.

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head:   1e67f149fb5eb4f5eb4e0d4f69194eac6d2497d7
commit: 3a0ea0feebe5cb529d57e0f9673d22e4754c6415 [643/1197] drm: xlnx: scaler: Adding vpss-scaler driver
config: mips-allmodconfig
compiler: mips-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/3a0ea0feebe5cb529d57e0f9673d22e4754c6415
        git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.15_LTS
        git checkout 3a0ea0feebe5cb529d57e0f9673d22e4754c6415
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/gpu/drm/xlnx/ drivers/media/platform/xilinx/ drivers/phy/xilinx/ drivers/staging/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/xlnx/xlnx_scaler.c: In function 'xilinx_scaler_stream':
>> drivers/gpu/drm/xlnx/xlnx_scaler.c:1394:21: warning: variable 'fmt_out' set but not used [-Wunused-but-set-variable]
    1394 |         u32 fmt_in, fmt_out;
         |                     ^~~~~~~
>> drivers/gpu/drm/xlnx/xlnx_scaler.c:1394:13: warning: variable 'fmt_in' set but not used [-Wunused-but-set-variable]
    1394 |         u32 fmt_in, fmt_out;
         |             ^~~~~~
--
>> drivers/gpu/drm/xlnx/xlnx_scaler.c:934: warning: expecting prototype for xv_hscaler_coeff_select(). Prototype was for xv_hscaler_select_coeff() instead
>> drivers/gpu/drm/xlnx/xlnx_scaler.c:1119: warning: expecting prototype for xv_vscaler_coeff_select(). Prototype was for xv_vscaler_select_coeff() instead


vim +/fmt_out +1394 drivers/gpu/drm/xlnx/xlnx_scaler.c

  1383	
  1384	/**
  1385	 * xilinx_scaler_stream - Set up v-scaler and h-scaler for streaming
  1386	 * @scaler: Pointer to scaler device structure
  1387	 *
  1388	 * This function sets up the required configuration of v-scaler and h-scaler
  1389	 *
  1390	 * Return: 0 on success. Returns -EINVAL on failure conditions.
  1391	 */
  1392	static int xilinx_scaler_stream(struct xilinx_scaler *scaler)
  1393	{
> 1394		u32 fmt_in, fmt_out;
  1395		u32 pixel_rate;
  1396		u32 line_rate;
  1397		int ret;
  1398	
  1399		fmt_in = scaler->fmt_in;
  1400		fmt_out = scaler->fmt_out;
  1401		line_rate = (scaler->height_in * STEP_PRECISION) / scaler->height_out;
  1402	
  1403		if (scaler->is_polyphase) {
  1404			ret = xv_vscaler_select_coeff(scaler, scaler->height_in,
  1405						      scaler->height_out);
  1406			if (ret < 0) {
  1407				dev_info(scaler->dev, "Failed: vscaler select coeff\n");
  1408				return ret;
  1409			}
  1410			xv_vscaler_set_coeff(scaler);
  1411		}
  1412		xilinx_scaler_write(scaler->base, V_VSCALER_OFF +
  1413				    XV_VSCALER_CTRL_ADDR_HWREG_LINERATE_DATA,
  1414				    line_rate);
  1415		ret = xv_vscaler_setup_video_fmt(scaler, scaler->fmt_in);
  1416		if (ret < 0) {
  1417			dev_info(scaler->dev, "Failed: vscaler setup video format\n");
  1418			return ret;
  1419		}
  1420		pixel_rate = (scaler->width_in * STEP_PRECISION) / scaler->width_out;
  1421		xilinx_scaler_write(scaler->base, V_HSCALER_OFF +
  1422				    XV_HSCALER_CTRL_ADDR_HWREG_PIXELRATE_DATA,
  1423				    pixel_rate);
  1424		ret = xv_hscaler_setup_video_fmt(scaler, scaler->fmt_out, ret);
  1425		if (ret < 0) {
  1426			dev_info(scaler->dev, "Failed: vscaler setup video format\n");
  1427			return ret;
  1428		}
  1429		if (scaler->is_polyphase) {
  1430			ret = xv_hscaler_select_coeff(scaler, scaler->width_in,
  1431						      scaler->width_out);
  1432			if (ret < 0) {
  1433				dev_info(scaler->dev, "Failed: hscaler select coeff\n");
  1434				return ret;
  1435			}
  1436			xv_hscaler_set_coeff(scaler);
  1437		}
  1438		xv_hscaler_calculate_phases(scaler, scaler->width_in,
  1439					    scaler->width_out, pixel_rate);
  1440		xv_hscaler_set_phases(scaler);
  1441		return 0;
  1442	}
  1443	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp