pci-exynos.c phy_init() usage

Bjorn Helgaas helgaas at kernel.org
Fri Jun 24 10:35:41 PDT 2022


In exynos_pcie_host_init() [1], we call:

  phy_reset(ep->phy);
  phy_power_on(ep->phy);
  phy_init(ep->phy);

The phy_init() function comment [2] says it must be called before
phy_power_on().  Is exynos doing this backwards?

Bjorn

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pci-exynos.c?id=v5.19-rc1#n252
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233



More information about the linux-arm-kernel mailing list