[PATCH 2/8] serial: core, 8250: set RS485 termination gpio in serial core
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Wed Jun 22 10:06:57 PDT 2022
On Wed, Jun 22, 2022 at 05:46:53PM +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo at kunbus.com>
>
> In serial8250_em485_config() the termination GPIO is set with the uart_port
> spinlock held. This is an issue if setting the GPIO line can sleep (e.g.
> since the concerning GPIO expander is connected via SPI or I2C).
>
> Fix this by setting the termination line outside of the uart_port spinlock
> in the serial core.
This doesn't describe that this patch is actually changing GPIO to support
sleep mode. So, it doesn't fix anything. Please rephrase the commit message
accordingly.
> This also makes setting the termination GPIO generic for all uart drivers.
UART
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list