[PATCH v2 3/3] arm64: dts: freescale: Add phyBOARD-Polis-i.MX8MM support

[Teresa Remmet]

Hello Shawn, 

Am Sonntag, dem 19.06.2022 um 13:07 +0800 schrieb Shawn Guo:
> 

[...]

> > +
> > +	reg_can_en: regulator-can-en {
> > +		compatible = "regulator-fixed";
> > +		gpio = <&gpio1 9 GPIO_ACTIVE_LOW>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_can_en>;
> > +		regulator-max-microvolt = <3300000>;
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-name = "CAN_EN";
> > +		startup-delay-us = <20>;
> > +	};
> > +
> > +	reg_usb_otg1_vbus: regulator-usb-otg1 {
> > +		compatible = "regulator-fixed";
> > +		enable-active-high;
> 
> Can we put 'enable-active-high' after 'gpio' line?

Sure.

[...]

> > 
> > +
> > +/* I2C1 */
> > +&i2c1 {
> > +	clock-frequency = <400000>;
> > +	pinctrl-names = "default","gpio";
> > +	pinctrl-0 = <&pinctrl_i2c1>;
> > +	pinctrl-1 = <&pinctrl_i2c1_gpio>;
> > +	scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> > +	sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> > +	status = "okay";
> > +
> > +	pmic at 8 {
> > +		compatible = "nxp,pf8121a";
> > +		reg = <0x08>;
> > +
> > +		regulators {
> > +			reg_nvcc_sd1: ldo1 {
> > +				regulator-always-on;
> > +				regulator-boot-on;
> > +				regulator-max-microvolt = <3300000>;
> > +				regulator-min-microvolt = <3300000>;
> > +				regulator-name = "NVCC_SD1 (LDO1)";
> 
> Have a newline between properties and child node.

I will add them.

[...]

> > +
> > +	eeprom at 51 {
> > +		compatible = "atmel,24c32";
> > +		pagesize = <32>;
> > +		reg = <0x51>;
> > +		vcc-supply = <&reg_vdd_3v3_s>;
> > +	};
> > +
> > +	sn65dsi83: bridge at 2d {
> 
> Sort I2C devices in unit-address.

Okay.

Thanks for your review. I will send a v3 with the requested changes.

Regards,
Teresa


> 
> Shawn
> 
-- 
PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE
149059855