[PATCH v2 1/9] dt-bindings: thermal: Define trips node in $defs

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Fri Jun 17 18:02:39 PDT 2022


On 17/06/2022 00:08, Francesco Dolcini wrote:
> Move `trips` definition to `#/$defs/trips-base` and just reference it
> from the trips node. This allows to easily re-use this binding from
> another binding file.
> 
> No functional changes expected.

If you want to re-use trips, they should be rather moved to separate
YAML file... but anyway this should not be done per-driver bindings, but
in more general way. Either the problem - using one DTS for different
temperature grades - looks generic or is wrong at the core. In the first
option, the generic bindings should be fixed. In the second case - using
same DTS for different HW is not correct approach and why only thermal
should be specific? I can imagine that cooling devices might have
different settings, regulator voltages for DVFS could be a bit different...

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list