[PATCH] arm: mach-versatile: Fix refcount leak bug in versatile

Liang He windhl at 126.com
Fri Jun 17 06:45:52 PDT 2022


In versatile_dt_init(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put() when
it is not used anymore.

Signed-off-by: Liang He <windhl at 126.com>
---
 arch/arm/mach-versatile/versatile.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-versatile/versatile.c b/arch/arm/mach-versatile/versatile.c
index 02ba68abe533..97da874b5d4b 100644
--- a/arch/arm/mach-versatile/versatile.c
+++ b/arch/arm/mach-versatile/versatile.c
@@ -164,6 +164,7 @@ static void __init versatile_dt_init(void)
 	np = of_find_compatible_node(NULL, NULL, "arm,core-module-versatile");
 	if (np)
 		versatile_sys_base = of_iomap(np, 0);
+	of_node_put(np);
 	WARN_ON(!versatile_sys_base);
 
 	versatile_dt_pci_init();
-- 
2.25.1




More information about the linux-arm-kernel mailing list