[EXT] Re: [PATCH 1/3] dt-bindings: crypto: fsl: add entropy delay property

[Vabhav Sharma]

Hello Rob,

> -----Original Message-----
> From: Rob Herring <robh at kernel.org>
> Sent: Monday, June 6, 2022 2:51 AM
> To: Vabhav Sharma <vabhav.sharma at nxp.com>
> Cc: Horia Geanta <horia.geanta at nxp.com>; Gaurav Jain
> <gaurav.jain at nxp.com>; Pankaj Gupta <pankaj.gupta at nxp.com>;
> herbert at gondor.apana.org.au; davem at davemloft.net;
> shawnguo at kernel.org; linux-crypto at vger.kernel.org; linux-
> kernel at vger.kernel.org; dl-linux-imx <linux-imx at nxp.com>;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Silvano Di
> Ninno <silvano.dininno at nxp.com>; Varun Sethi <V.Sethi at nxp.com>
> Subject: [EXT] Re: [PATCH 1/3] dt-bindings: crypto: fsl: add entropy delay
> property
> 
> Caution: EXT Email
> 
> On Mon, May 30, 2022 at 11:39:22PM +0530, Vabhav Sharma wrote:
> > Add entropy delay property which defines the length (in system clocks)
> > of each Entropy sample taken for TRNG configuration.
> >
> > Signed-off-by: Vabhav Sharma <vabhav.sharma at nxp.com>
> > Reviewed-by: Horia Geanta <horia.geanta at nxp.com>
> > Reviewed-by: Varun Sethi <v.sethi at nxp.com>
> > ---
> >  Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> > b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> > index 8f359f473ada..1477294eda38 100644
> > --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> > +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> > @@ -62,6 +62,12 @@ PROPERTIES
> >        Definition: A standard property. Define the 'ERA' of the SEC
> >            device.
> >
> > +   - entropy-delay
> > +      Usage: optional
> > +      Value type: <u32>
> > +      Definition: A property which specifies the length (in system clocks)
> > +          of each Entropy sample taken.
> > +
> 
> Seems like this could be common, but should be a time value (with unit
> suffix) rather than clocks. If not common, then needs a vendor prefix.
> Is this time to read a value or time between values produced? Not really clear
> from the description.
CAAM TRNG Configuration includes 16-bit field entropy-delay. This field specifies how long the oscillator is given to freely oscillate and generate a single bit of entropy.
It is specified as number of system clock cycles and this u32 type field already exist in the caam driver code with default value of 3200. However, on some platform this value can vary and support is added to read the value from device tree in order to override default value, Hope this helps to clarify.
> 
> Rob