[PATCH v2] dmaengine: apple-admac: Use {low,upp}er_32_bits() to split 64-bit address

Vinod Koul vkoul at kernel.org
Thu Jun 16 07:17:05 PDT 2022


On 16-06-22, 16:13, Geert Uytterhoeven wrote:
> If CONFIG_PHYS_ADDR_T_64BIT is not set:
> 
>     drivers/dma/apple-admac.c: In function ‘admac_cyclic_write_one_desc’:
>     drivers/dma/apple-admac.c:213:22: error: right shift count >= width of type [-Werror=shift-count-overflow]
>       213 |  writel_relaxed(addr >> 32,       ad->base + REG_DESC_WRITE(channo));
>           |                      ^~
> 
> Fix this by using the {low,upp}er_32_bits() helper macros to obtain the
> address parts.

Applied, thanks

-- 
~Vinod



More information about the linux-arm-kernel mailing list