[PATCH] arm64/cpufeature: Unexport set_cpu_feature()

[Mark Rutland]

On Wed, Jun 15, 2022 at 08:15:04PM +0100, Mark Brown wrote:
> We currently export set_cpu_feature() to modules but there are no in tree
> users that can be built as modules and it is hard to see cases where it
> would make sense for there to be any such users. Remove the export to avoid
> anyone else having to worry about why it is there and ensure that any users
> that do get added get a bit more visiblity.
> 
> Signed-off-by: Mark Brown <broonie at kernel.org>

Looking through the git history, the exposed was added in commit:

  aec0bff757c93748 ("arm64: HWCAP: encapsulate elf_hwcap")

... but even then there didn't appear to be any in-tree modular user, and the
commit message didn't explain why.

Otherwise, this definitely seems like something we shouldn't be exporting, so
FWIW:

  Reviewed-by: Mark Rutland <mark.rutland at arm.com>

Mark.

> ---
>  arch/arm64/kernel/cpufeature.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index 79fac13ab2ef..8d88433de81d 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -3101,7 +3101,6 @@ void cpu_set_feature(unsigned int num)
>  	WARN_ON(num >= MAX_CPU_FEATURES);
>  	elf_hwcap |= BIT(num);
>  }
> -EXPORT_SYMBOL_GPL(cpu_set_feature);
>  
>  bool cpu_have_feature(unsigned int num)
>  {
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel