[PATCH] arm64/cpufeature: Unexport set_cpu_feature()

Suzuki K Poulose suzuki.poulose at arm.com
Thu Jun 16 01:57:27 PDT 2022


On 15/06/2022 20:15, Mark Brown wrote:
> We currently export set_cpu_feature() to modules but there are no in tree
> users that can be built as modules and it is hard to see cases where it
> would make sense for there to be any such users. Remove the export to avoid
> anyone else having to worry about why it is there and ensure that any users
> that do get added get a bit more visiblity.
> 
> Signed-off-by: Mark Brown <broonie at kernel.org>

Also, it doesn't sound safe to expose this to the modules anyways.

Acked-by: Suzuki K Poulose <suzuki.poulose at arm.com>

> ---
>   arch/arm64/kernel/cpufeature.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index 79fac13ab2ef..8d88433de81d 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -3101,7 +3101,6 @@ void cpu_set_feature(unsigned int num)
>   	WARN_ON(num >= MAX_CPU_FEATURES);
>   	elf_hwcap |= BIT(num);
>   }
> -EXPORT_SYMBOL_GPL(cpu_set_feature);
>   
>   bool cpu_have_feature(unsigned int num)
>   {




More information about the linux-arm-kernel mailing list