[PATCH v2] drivers: clk: (clk-nomadik) Add missing of_node_put()
Liang He
windhl at 126.com
Wed Jun 15 20:24:48 PDT 2022
In nomadik_src_init, of_find_matching_node() return a node pointer
with refcount incremented. We should use of_node_put() in fail path
or when it is not used anymore.
Signed-off-by: Liang He <windhl at 126.com>
---
changelog:
v2: (1) use real name for Sob (2) use goto-label patch style
(3) use proper subject title
v1: use two of_node_put() in fail path and normal-return
drivers/clk/clk-nomadik.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index bad2677e11ae..48d5772b36a5 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
if (!src_base) {
pr_err("%s: must have src parent node with REGS (%pOFn)\n",
__func__, np);
- return;
+ goto out_put;
}
/* Set all timers to use the 2.4 MHz TIMCLK */
@@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
}
writel(val, src_base + SRC_XTALCR);
register_reboot_notifier(&nomadik_clk_reboot_notifier);
+
+output:
+ of_node_put(np);
}
/**
--
2.25.1
More information about the linux-arm-kernel
mailing list