[PATCH 1/4] clk: imx: imx8mp: Add audiomix block control

[Marek Vasut]

On 6/15/22 17:56, Abel Vesa wrote:
> On 22-06-15 18:47:01, Abel Vesa wrote:
>> On 22-06-15 17:08:28, Marek Vasut wrote:
>>> On 6/15/22 16:30, Abel Vesa wrote:
>>>
>>> [...]
>>>
>>>>> +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev)
>>>>> +{
>>>>> +	struct clk_imx8mp_audiomix_priv *priv;
>>>>> +	struct device *dev = &pdev->dev;
>>>>> +	struct resource *res;
>>>>> +	void __iomem *base;
>>>>> +	struct clk_hw *hw;
>>>>> +	int i;
>>>>> +
>>>>> +	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>>>>> +	if (!priv)
>>>>> +		return -ENOMEM;
>>>>> +
>>>>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>>>> +	base = devm_ioremap_resource(dev, res);
>>>>> +	if (IS_ERR(base))
>>>>> +		return PTR_ERR(base);
>>>>> +
>>>>
>>>> Hmm, the audiomix blk-ctl driver uses the PD for this device.
>>>> That is not going to work.
>>>
>>> What is not going to work. Can you elaborate on your concerns ?
>>
>> Have a look at drivers/soc/imx/imx8m-blk-ctrl.c.
>>
>> As of now, there is no i.MX8MP audio blk ctrl support added there yet,
>> but once that gets added, that driver will disable the PD from under
>> this clock controller.
> 
> On a second thought, I remember there was a discussion about this being
> implemented entirely in imx8m-blk-ctrl.c.

This is purely a clock driver within the PGC audio domain, see the DT 
bindings in 3/4 patch. I don't expect there to be any PD related issues.