[PATCH 1/4] clk: imx: imx8mp: Add audiomix block control

Abel Vesa abel.vesa at nxp.com
Wed Jun 15 08:47:01 PDT 2022


On 22-06-15 17:08:28, Marek Vasut wrote:
> On 6/15/22 16:30, Abel Vesa wrote:
>
> [...]
>
> > > +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev)
> > > +{
> > > +	struct clk_imx8mp_audiomix_priv *priv;
> > > +	struct device *dev = &pdev->dev;
> > > +	struct resource *res;
> > > +	void __iomem *base;
> > > +	struct clk_hw *hw;
> > > +	int i;
> > > +
> > > +	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > > +	if (!priv)
> > > +		return -ENOMEM;
> > > +
> > > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > +	base = devm_ioremap_resource(dev, res);
> > > +	if (IS_ERR(base))
> > > +		return PTR_ERR(base);
> > > +
> >
> > Hmm, the audiomix blk-ctl driver uses the PD for this device.
> > That is not going to work.
>
> What is not going to work. Can you elaborate on your concerns ?

Have a look at drivers/soc/imx/imx8m-blk-ctrl.c.

As of now, there is no i.MX8MP audio blk ctrl support added there yet,
but once that gets added, that driver will disable the PD from under
this clock controller.



More information about the linux-arm-kernel mailing list