[PATCH v1 0/9] imx: thermal: Allow trip point configuration from DT
Francesco Dolcini
francesco.dolcini at toradex.com
Wed Jun 15 02:47:55 PDT 2022
This series allows to specify the imx thermal drivers trip point from the device tree,
without this change the threshold are hard-coded and this might not be correct given the
thermal design of the final system.
This change is backward compatible with the existing device tree, and even
with this change in by default the thresholds are the same as before.
Toradex board are also updated to use a system-specific thresholds.
Discussion on the current design is here:
https://lore.kernel.org/all/4ba1d7d2-3e8c-ba60-37fd-9598f415c076@linaro.org/
One side note, after this change the dtbs checker starts complaining with this message
```
linux/arch/arm/boot/dts/imx6dl-alti6p.dtb: tempmon: '#thermal-sensor-cells' does not match any of the regexes: '^(automotive|commercial|extended-commercial|industrial)-thermal$', 'pinctrl-[0-9]+'
From schema: linux/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
```
to my understanding this is just a side effect, '#thermal-sensor-cells' is not changed in
any way by this series. I can fix that, I wonder if I should remove the property from the
imx dtsi files or add it to the binding yaml definition, not sure about it.
Anybody can advise?
Francesco Dolcini (9):
dt-bindings: thermal: Define trips node in $defs
thermal: thermal: Export OF trip helper function
dt-bindings: thermal: imx: Add trips point
imx: thermal: Configure trip point from DT
ARM: dts: imx[67]: Add trips points
ARM: dts: imx6qdl-apalis: Set CPU critical trip point
ARM: dts: imx7-colibri: Set CPU critical trip point
ARM: dts: imx6ull-colibri: Set CPU critical trip point
ARM: dts: imx6qdl-colibri: Set CPU critical trip point
.../bindings/thermal/imx-thermal.yaml | 27 ++++
.../bindings/thermal/thermal-zones.yaml | 130 +++++++++---------
arch/arm/boot/dts/imx-thermal.dtsi | 61 ++++++++
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 12 ++
arch/arm/boot/dts/imx6qdl-colibri.dtsi | 12 ++
arch/arm/boot/dts/imx6qdl.dtsi | 2 +
arch/arm/boot/dts/imx6sl.dtsi | 2 +
arch/arm/boot/dts/imx6sll.dtsi | 2 +
arch/arm/boot/dts/imx6sx.dtsi | 2 +
arch/arm/boot/dts/imx6ul.dtsi | 2 +
arch/arm/boot/dts/imx6ull-colibri.dtsi | 12 ++
arch/arm/boot/dts/imx7-colibri.dtsi | 12 ++
arch/arm/boot/dts/imx7s.dtsi | 2 +
drivers/thermal/imx_thermal.c | 49 +++++++
drivers/thermal/thermal_core.h | 7 +
drivers/thermal/thermal_of.c | 5 +-
16 files changed, 274 insertions(+), 65 deletions(-)
create mode 100644 arch/arm/boot/dts/imx-thermal.dtsi
--
2.25.1
More information about the linux-arm-kernel
mailing list