[PATCH net-next v4 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN support

[Ong, Boon Leong]

>On Tue, Jun 14, 2022 at 11:00:28AM +0800, Ong Boon Leong wrote:
>> +int xpcs_modify_changed(struct dw_xpcs *xpcs, int dev, u32 reg,
>> +			u16 mask, u16 set)
>
>Why is this globally visible? I can find no reason for it in this patch
>set.
Ok. I will make it private.

>
>> +{
>> +	u32 reg_addr = mdiobus_c45_addr(dev, reg);
>> +	struct mii_bus *bus = xpcs->mdiodev->bus;
>> +	int addr = xpcs->mdiodev->addr;
>> +
>> +	return mdiobus_modify_changed(bus, addr, reg_addr, mask, set);
>
>There is a mdiodev_modify_changed() which would be slightly cleaner
>here.
>
Interesting. I could also add another patch to make the same change to
xpcs_read() and xpcs_write(). Ok?