[PATCH v11 07/12] drm/mediatek: dpi: move swap_shift to SoC config
CK Hu
ck.hu at mediatek.com
Mon Jun 13 22:38:39 PDT 2022
Hi, Bo-Chen:
On Mon, 2022-06-13 at 14:48 +0800, Bo-Chen Chen wrote:
> From: Guillaume Ranquet <granquet at baylibre.com>
>
> Add flexibility by moving the swap shift value to SoC specific
> config.
Reviewed-by: CK Hu <ck.hu at mediatek.com>
>
> Signed-off-by: Guillaume Ranquet <granquet at baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen at mediatek.com>
> Reviewed-by: Rex-BC Chen <rex-bc.chen at mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno at collabora.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index afd81ae307da..2c0e9670c209 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -131,6 +131,7 @@ struct mtk_dpi_conf {
> u32 dimension_mask;
> /* HSIZE and VSIZE mask (no shift) */
> u32 hvsize_mask;
> + u32 channel_swap_shift;
> const struct mtk_dpi_yc_limit *limit;
> };
>
> @@ -349,7 +350,9 @@ static void mtk_dpi_config_channel_swap(struct
> mtk_dpi *dpi,
> break;
> }
>
> - mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << CH_SWAP,
> CH_SWAP_MASK);
> + mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING,
> + val << dpi->conf->channel_swap_shift,
> + CH_SWAP_MASK << dpi->conf->channel_swap_shift);
> }
>
> static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool
> enable)
> @@ -821,6 +824,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
> .swap_input_support = true,
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> + .channel_swap_shift = CH_SWAP,
> .limit = &mtk_dpi_limit,
> };
>
> @@ -835,6 +839,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
> .swap_input_support = true,
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> + .channel_swap_shift = CH_SWAP,
> .limit = &mtk_dpi_limit,
> };
>
> @@ -848,6 +853,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
> .swap_input_support = true,
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> + .channel_swap_shift = CH_SWAP,
> .limit = &mtk_dpi_limit,
> };
>
> @@ -861,6 +867,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
> .swap_input_support = true,
> .dimension_mask = HPW_MASK,
> .hvsize_mask = HSIZE_MASK,
> + .channel_swap_shift = CH_SWAP,
> .limit = &mtk_dpi_limit,
> };
>
More information about the linux-arm-kernel
mailing list