[PATCH 1/8] dt-bindings: soc: imx: add interconnect property for i.MX8MP media blk ctrl

[Peng Fan]

> Subject: Re: [PATCH 1/8] dt-bindings: soc: imx: add interconnect property for
> i.MX8MP media blk ctrl
> 
> Hi Peng,
> 
> Thank you for the patch.
> 
> On Wed, Jun 01, 2022 at 05:45:30PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan at nxp.com>
> >
> > Add interconnect property for i.MX8MP mediamix blk ctrl
> >
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > ---
> >  .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml         | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.
> > yaml
> > b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.
> > yaml index 21d3ee486295..706bef39b87e 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.
> > yaml
> > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-c
> > +++ trl.yaml
> > @@ -64,6 +64,20 @@ properties:
> >        - const: isp
> >        - const: phy
> >
> > +  interconnects:
> > +    maxItems: 8
> > +
> > +  interconnect-names:
> > +    items:
> > +      - const: lcdif-rd
> > +      - const: lcdif-wr
> > +      - const: isi0
> > +      - const: isi1
> > +      - const: isi2
> 
> If I understand correctly, these are for the 1x RD and 2x WR channels of the ISI.
> Would it make sense to name thim accordingly, maybe isi-rd,
> isi-wr0 and isi-wr1 ? I'm not sure about the order though.

From the doc I get, they are isi0/1/2, so I would keep them as it is.

Thanks,
Peng.

> 
> > +      - const: isp0
> > +      - const: isp1
> > +      - const: dwe
> > +
> >  required:
> >    - compatible
> >    - reg
> 
> --
> Regards,
> 
> Laurent Pinchart