[PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

[Stefan Wahren]

Hi Peter,

Am 01.06.22 um 13:02 schrieb Peter Robinson:
> This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4)
> and the associated firmware clock entry.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne at suse.de>
> Signed-off-by: Peter Robinson <pbrobinson at gmail.com>
> ---
> Changes since v5:
> - Move the firmware clock to bcm2711-rpi.dtsi
>
>   arch/arm/boot/dts/bcm2711-rpi.dtsi |  4 ++++
>   arch/arm/boot/dts/bcm2711.dtsi     | 11 +++++++++++
>   2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711-rpi.dtsi b/arch/arm/boot/dts/bcm2711-rpi.dtsi
> index ca266c5d9f9b..98817a6675b9 100644
> --- a/arch/arm/boot/dts/bcm2711-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2711-rpi.dtsi
> @@ -69,6 +69,10 @@ blconfig: nvram at 0 {
>   	};
>   };
>   
> +&v3d {
> +	clocks = <&firmware_clocks 5>;
> +};
> +
>   &vchiq {
>   	interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
>   };
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index 89af57482bc8..177662257b16 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -601,6 +601,17 @@ genet_mdio: mdio at e14 {
>   				#size-cells = <0x0>;
>   			};
>   		};
> +
> +		v3d: gpu at 7ec00000 {
> +			compatible = "brcm,bcm2711-v3d";

unfortunately this doesn't match with patch #3 anymore. Except of this 
everything looks good here.

Stefan

> +			reg = <0x0 0x7ec00000 0x4000>,
> +			      <0x0 0x7ec04000 0x4000>;
> +			reg-names = "hub", "core0";
> +
> +			power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
> +			resets = <&pm BCM2835_RESET_V3D>;
> +			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> +		};
>   	};
>   };
>