[PATCH v1 08/14] regulator: drivers: Add TI TPS65219 PMIC regulators support

Mark Brown broonie at kernel.org
Fri Jul 22 11:40:04 PDT 2022


On Fri, Jul 22, 2022 at 03:30:11PM +0200, jerome Neanne wrote:
> > @@ -0,0 +1,414 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * tps65219-regulator.c
> > + *

> Please make the entire comment a C++ one so things look more
> intentional.

> checkpatch is complaining about that:

> ---------------------------------------------------------------------
> v5.19-rc6-PB-MSP1/0005-mfd-drivers-Add-TI-TPS65219-PMIC-support.patch
> ---------------------------------------------------------------------
> WARNING: Improper SPDX comment style for 'drivers/mfd/tps65219.c', please
> use '//' instead
> #91: FILE: drivers/mfd/tps65219.c:1:
> +/* SPDX-License-Identifier: GPL-2.0

> Let me know if I should ignore checkpatch recommendations here.

checkpatch is complaining about you having written a C comment there,
I'm asking you to make the entire block a C++ comment.  checkpatch won't
complain if you do that.

Please fix your mail client to clearly indicate quoted sections of text,
it's quite hard to read things as they are.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20220722/7515d906/attachment.sig>


More information about the linux-arm-kernel mailing list