[PATCH 2/2] ARM: dts: lan966x: add support for pcb8309

[Horatiu Vultur - M31836]

The 07/21/2022 06:08, Kavyasree Kotagiri - I30978 wrote:
> > +	i2c-mux {
> > +		compatible = "i2c-mux";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		mux-controls = <&mux>;
> > +		i2c-parent = <&i2c4>;
> > +
> > +		i2c102: i2c-sfp at 1 {
> > +			reg = <1>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> 
> Why do you need #address-cells and #size-cells here?
> > +		};
> > +
> > +		i2c103: i2c-sfp at 2 {
> > +			reg = <2>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> Same here
> > +		};
> > +	};

They are not needed. I will remove them in the next version.
> > +
> > +	mux: mux-controller {
> > +		compatible = "gpio-mux";
> > +		#mux-control-cells = <0>;
> > +
> > +		mux-gpios = <&sgpio_out 11 0 GPIO_ACTIVE_HIGH>, /*
> > p11b0 */
> > +			    <&sgpio_out 11 1 GPIO_ACTIVE_HIGH>; /* p11b1
> > */
> > +	};

...

> > +&i2c4 {
> > +	compatible = "microchip,sam9x60-i2c";
> > +	reg = <0x600 0x200>;
> > +	interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> > +	#address-cells = <1>;
> > +	#size-cells = <0>;
> 
> Same here 
> 

Also here.

-- 
/Horatiu