[PATCH net-next v3 27/47] net: fman: Inline several functions into initialization

[Camelia Alexandra Groza]

> -----Original Message-----
> From: Sean Anderson <sean.anderson at seco.com>
> Sent: Thursday, July 21, 2022 18:34
> To: Camelia Alexandra Groza <camelia.groza at nxp.com>; David S . Miller
> <davem at davemloft.net>; Jakub Kicinski <kuba at kernel.org>; Madalin Bucur
> <madalin.bucur at nxp.com>; netdev at vger.kernel.org
> Cc: Paolo Abeni <pabeni at redhat.com>; Eric Dumazet
> <edumazet at google.com>; linux-arm-kernel at lists.infradead.org; Russell
> King <linux at armlinux.org.uk>; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into initialization
> 
> 
> 
> On 7/21/22 9:01 AM, Camelia Alexandra Groza wrote:
> >> -----Original Message-----
> >> From: Sean Anderson <sean.anderson at seco.com>
> >> Sent: Saturday, July 16, 2022 1:00
> >> To: David S . Miller <davem at davemloft.net>; Jakub Kicinski
> >> <kuba at kernel.org>; Madalin Bucur <madalin.bucur at nxp.com>;
> >> netdev at vger.kernel.org
> >> Cc: Paolo Abeni <pabeni at redhat.com>; Eric Dumazet
> >> <edumazet at google.com>; linux-arm-kernel at lists.infradead.org; Russell
> >> King <linux at armlinux.org.uk>; linux-kernel at vger.kernel.org; Sean
> Anderson
> >> <sean.anderson at seco.com>
> >> Subject: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into
> >> initialization
> >>
> >> There are several small functions which weer only necessary because the
> >
> > *were* typo.
> 
> Hm, I thought commit messages were supposed to be written as if the patch
> hadn't
> yet been applied (e.g. the current state as the patch is reviewed).

That's my understanding as well. I was pointing out this bit: "which weer only necessary ".
I assume you wanted to type "were" here.

> >> initialization functions didn't have access to the mac private data. Now
> >> that they do, just do things directly.
> >>
> >> Signed-off-by: Sean Anderson <sean.anderson at seco.com>
> >
> > Acked-by: Camelia Groza <camelia.groza at nxp.com>
> >