[PATCH] ARM: pxa: spitz: Fix GPIO dev_name for SPI devices

Linus Walleij linus.walleij at linaro.org
Fri Jul 22 04:49:15 PDT 2022


On Fri, Jul 22, 2022 at 11:11 AM Arnd Bergmann <arnd at arndb.de> wrote:
> On Thu, Jul 21, 2022 at 11:06 PM Laurence de Bruxelles
> <lfdebrux at gmail.com> wrote:

> > One thing I'm not clear on is whether the same change needs to be made
> > to other PXA devices. The previous commit affected 10 devices, this
> > commit only fixes one, but I only have hardware for that one, so
> > possibly other hardware is different.
> >
> > Fixes: 31455bbda208 ("spi: pxa2xx_spi: Convert to use GPIO descriptors")
>
> I think all the previous conversions were done blindly, so it's most likely that
> everything needs the same change.
>
> Linus, can you have a look at this? I don't understand where the name is
> supposed to come from, and importantly what the best fix is. I assume we
> can address this either by changing all the board files to use the correct
> dev_id, or by changing the gpio drivers to change the ID of the gpio
> controller to be what we expected it to be.

I'm surprised the change was so small to make things actually work,
one of the best side effects is that we now know that Laurence is
using the Zaurus!

I have sent a patch fixing up all the sites with Laurence as reporter.

Laurence: please consider signing up as maintainer of the Zaurus/spitz
in MAINTAINERS, also possibly start looking at a DT conversion :)

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list