[PATCH 1/2] dmaengine: xilinx_dma: Fix probe error cleanup

[Vinod Koul]

On 12-07-22, 07:36, Agarwal, Swati wrote:
> Hi Vinod,
> 
> > -----Original Message-----
> > From: Vinod Koul <vkoul at kernel.org>
> > Sent: Friday, July 1, 2022 5:21 PM
> > To: Swati Agarwal <swati.agarwal at xilinx.com>
> > Cc: lars at metafoo.de; adrianml at alumnos.upm.es; libaokun1 at huawei.com;
> > marex at denx.de; dmaengine at vger.kernel.org; linux-arm-
> > kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> > harini.katakam at xilinx.com; radhey.shyam.pandey at xilinx.com;
> > michal.simek at xilinx.com
> > Subject: Re: [PATCH 1/2] dmaengine: xilinx_dma: Fix probe error cleanup
> > 
> > CAUTION: This message has originated from an External Source. Please use
> > proper judgment and caution when opening attachments, clicking links, or
> > responding to this email.
> > 
> > 
> > On 24-06-22, 12:05, Swati Agarwal wrote:
> > > When probe fails remove dma channel resources and disable clocks in
> > > accordance with the order of resources allocated .
> > 
> > Ok this looks fine and the changes below..
> 
> Thanks for the review!!
> Sorry for the delayed reply. I missed this mail due to some mailer issues.
> 
> > >
> > > Add missing cleanup in devm_platform_ioremap_resource(),
> > > xlnx,num-fstores property.
> > 
> > Where is this part?
> 
> The statement is an elaboration of the previous one. The relevant code is below.

Okay, a patch should do only One thing, pls consider splitting it up...

> 
> <snip>
> > >       /* Request and map I/O memory */
> > >       xdev->regs = devm_platform_ioremap_resource(pdev, 0);
> > > -     if (IS_ERR(xdev->regs))
> > > -             return PTR_ERR(xdev->regs);
> > > +     if (IS_ERR(xdev->regs)) {
> > > +             err = PTR_ERR(xdev->regs);
> > > +             goto disable_clks;
> > > +     }
> 
> This  
> 
> <snip>
> > >               if (err < 0) {
> > >                       dev_err(xdev->dev,
> > >                               "missing xlnx,num-fstores property\n");
> > > -                     return err;
> > > +                     goto disable_clks;
> > >               }
> 
> And this
> 
> Regards,
> Swati Agarwal

-- 
~Vinod