[PATCH net-next v3 29/47] net: fman: Map the base address once
Camelia Alexandra Groza
camelia.groza at nxp.com
Thu Jul 21 06:04:37 PDT 2022
> -----Original Message-----
> From: Sean Anderson <sean.anderson at seco.com>
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem at davemloft.net>; Jakub Kicinski
> <kuba at kernel.org>; Madalin Bucur <madalin.bucur at nxp.com>;
> netdev at vger.kernel.org
> Cc: Paolo Abeni <pabeni at redhat.com>; Eric Dumazet
> <edumazet at google.com>; linux-arm-kernel at lists.infradead.org; Russell
> King <linux at armlinux.org.uk>; linux-kernel at vger.kernel.org; Sean Anderson
> <sean.anderson at seco.com>
> Subject: [PATCH net-next v3 29/47] net: fman: Map the base address once
>
> We don't need to remap the base address from the resource twice (once in
> mac_probe() and again in set_fman_mac_params()). We still need the
> resource to get the end address, but we can use a single function call
> to get both at once.
>
> While we're at it, use platform_get_mem_or_io and
> devm_request_resource
> to map the resource. I think this is the more "correct" way to do things
> here, since we use the pdev resource, instead of creating a new one.
> It's still a bit tricy, since we need to ensure that the resource is a
*tricky* typo
> child of the fman region when it gets requested.
>
> Signed-off-by: Sean Anderson <sean.anderson at seco.com>
Acked-by: Camelia Groza <camelia.groza at nxp.com>
More information about the linux-arm-kernel
mailing list