[PATCH net-next v3 20/47] net: fman: Store initialization function in match data

Camelia Alexandra Groza camelia.groza at nxp.com
Thu Jul 21 05:51:21 PDT 2022


> -----Original Message-----
> From: Sean Anderson <sean.anderson at seco.com>
> Sent: Saturday, July 16, 2022 0:59
> To: David S . Miller <davem at davemloft.net>; Jakub Kicinski
> <kuba at kernel.org>; Madalin Bucur <madalin.bucur at nxp.com>;
> netdev at vger.kernel.org
> Cc: Paolo Abeni <pabeni at redhat.com>; Eric Dumazet
> <edumazet at google.com>; linux-arm-kernel at lists.infradead.org; Russell
> King <linux at armlinux.org.uk>; linux-kernel at vger.kernel.org; Sean Anderson
> <sean.anderson at seco.com>
> Subject: [PATCH net-next v3 20/47] net: fman: Store initialization function in
> match data
> 
> Instead of re-matching the compatible string in order to determine the
> init function, just store it in the match data. This also move the setting
> of the rest of the functions into init as well. 

This last sentence can be rephrased to be clearer. Maybe something like:
The separate setup functions aren't needed anymore. Merge their content
into init as well.

> To ensure everything
> compiles correctly, we move them to the bottom of the file.
> 
> Signed-off-by: Sean Anderson <sean.anderson at seco.com>

Acked-by: Camelia Groza <camelia.groza at nxp.com>




More information about the linux-arm-kernel mailing list