[PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node
Gregory CLEMENT
gregory.clement at bootlin.com
Mon Jul 18 03:43:04 PDT 2022
Marek Behún <kabel at kernel.org> writes:
> The LED controller node is disabled because the leds-turris-omnia driver
> does not support setting the LED blinking to be controlled by the MCU.
>
> The patches for that have now been sent [1], so let's enable the node.
>
> [1] https://lore.kernel.org/linux-leds/20220704105955.15474-1-kabel@kernel.org/T/
>
> Signed-off-by: Marek Behún <kabel at kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index 1583c4b14ae8..d1e0db6e5730 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -191,15 +191,13 @@ led-controller at 2b {
> reg = <0x2b>;
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "okay";
>
> /*
> * LEDs are controlled by MCU (STM32F0) at
> * address 0x2b.
> *
> - * The driver does not support HW control mode
> - * for the LEDs yet. Disable the LEDs for now.
> - *
> - * Also LED functions are not stable yet:
> + * LED functions are not stable yet:
> * - there are 3 LEDs connected via MCU to PCIe
> * ports. One of these ports supports mSATA.
> * There is no mSATA nor PCIe function.
> @@ -210,7 +208,6 @@ led-controller at 2b {
> * B. Again there is no such function defined.
> * For now we use LED_FUNCTION_INDICATOR
> */
> - status = "disabled";
>
> multi-led at 0 {
> reg = <0x0>;
> --
> 2.35.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
More information about the linux-arm-kernel
mailing list