[PATCH RFC v2 0/6] net: dsa: always use phylink

Marcin Wojtas mw at semihalf.com
Fri Jul 15 01:30:37 PDT 2022


Hi,

śr., 13 lip 2022 o 16:16 Russell King (Oracle) <linux at armlinux.org.uk>
napisał(a):
>
> Hi,
>
> This is a re-hash of the previous RFC series, this time using the
> suggestion from Vladimir to create a swnode based fixed-link
> specifier.
>
> Most of the changes are to DSA and phylink code from the previous
> series. I've tested on my Clearfog (which has just one Marvell DSA
> switch) and it works there - also tested without the fixed-link
> specified in DT.
>
>  drivers/base/swnode.c                  |  14 ++-
>  drivers/net/dsa/b53/b53_common.c       |   3 +-
>  drivers/net/dsa/bcm_sf2.c              |   3 +-
>  drivers/net/dsa/hirschmann/hellcreek.c |   3 +-
>  drivers/net/dsa/lantiq_gswip.c         |   6 +-
>  drivers/net/dsa/microchip/ksz_common.c |   3 +-
>  drivers/net/dsa/mt7530.c               |   3 +-
>  drivers/net/dsa/mv88e6xxx/chip.c       | 134 ++++++++++++-------------
>  drivers/net/dsa/mv88e6xxx/chip.h       |   6 +-
>  drivers/net/dsa/mv88e6xxx/port.c       |  32 ------
>  drivers/net/dsa/mv88e6xxx/port.h       |   5 -
>  drivers/net/dsa/ocelot/felix.c         |   3 +-
>  drivers/net/dsa/qca/ar9331.c           |   3 +-
>  drivers/net/dsa/qca8k.c                |   3 +-
>  drivers/net/dsa/realtek/rtl8365mb.c    |   3 +-
>  drivers/net/dsa/sja1105/sja1105_main.c |   3 +-
>  drivers/net/dsa/xrs700x/xrs700x.c      |   3 +-
>  drivers/net/phy/phylink.c              |  30 ++++--
>  include/linux/phylink.h                |   1 +
>  include/linux/property.h               |   4 +
>  include/net/dsa.h                      |   3 +-
>  net/dsa/port.c                         | 175 +++++++++++++++++++++++++++++----
>  22 files changed, 290 insertions(+), 153 deletions(-)
>

I tested the patchset on top of net-next/master alone and with my
fwnode_/ACPI patchset:
* On EspressoBIN
* On SolidRun CN913x CEx7 Eval Board
  - with DT (with and without fixed-link description in CPU port)
  - with ACPI (with and without fixed-link description in CPU port)

All works as expected, so:
Tested-by: Marcin Wojtas <mw at semihalf.com>

FWIW, the patches LGTM:
Reviewed-by: Marcin Wojtas <mw at semihalf.com>

Best regards,
Marcin



More information about the linux-arm-kernel mailing list