[PATCH] dmaengine: xilinx: use strscpy to replace strlcpy
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Jul 11 09:37:09 PDT 2022
Hi XueBing,
Thank you for the patch.
On Mon, Jul 11, 2022 at 10:05:33PM +0800, XueBing Chen wrote:
>
> The strlcpy should not be used because it doesn't limit the source
> length. Preferred is strscpy.
>
> Signed-off-by: XueBing Chen <chenxuebing at jari.cn>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index b0f4948b00a5..f5815465e83b 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -376,7 +376,7 @@ static ssize_t xilinx_dpdma_debugfs_read(struct file *f, char __user *buf,
> if (ret < 0)
> goto done;
> } else {
> - strlcpy(kern_buff, "No testcase executed",
> + strscpy(kern_buff, "No testcase executed",
> XILINX_DPDMA_DEBUGFS_READ_MAX_SIZE);
> }
>
--
Regards,
Laurent Pinchart
More information about the linux-arm-kernel
mailing list