DSA: request for your help with your DSA driver

Russell King (Oracle) linux at armlinux.org.uk
Tue Jul 5 07:11:31 PDT 2022


On Tue, Jul 05, 2022 at 01:45:42PM +0000, Alvin Šipraga wrote:
> For drivers/net/dsa/realtek/rtl8365mb:
> 
> I think we are OK. The .phylink_get_caps op will populate
> supported_interfaces faithfully for all port types, so in the absence of
> a fixed-link I think it is perfectly fine for phylink to calculate the
> highest speed interface and use that. The driver and hardware will be
> able to support whatever it advertises.
> 
> From reading the series I understand that the behaviour for DTs with
> fixed-link will remain unchanged.
> 
> With the above in mind, I think it's fine not to set default_interface
> in the .phylink_get_caps callback? This means "let phylink decide the
> most suitable default".

Yes, that is correct. Thanks for taking a look.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!



More information about the linux-arm-kernel mailing list