[PATCH 02/20] dt-bindings: media: s5p-mfc: Convert s5p-mfc.txt to new DT schema

[Krzysztof Kozlowski]

On 05/07/2022 13:44, Smitha T Murthy wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski at linaro.org]
>> Sent: Tuesday, May 17, 2022 7:26 PM
>> To: Smitha T Murthy <smitha.t at samsung.com>; linux-arm-
>> kernel at lists.infradead.org; linux-media at vger.kernel.org; linux-
>> kernel at vger.kernel.org; devicetree at vger.kernel.org
>> Cc: m.szyprowski at samsung.com; andrzej.hajda at intel.com;
>> mchehab at kernel.org; hverkuil-cisco at xs4all.nl;
>> ezequiel at vanguardiasur.com.ar; jernej.skrabec at gmail.com;
>> benjamin.gaignard at collabora.com; stanimir.varbanov at linaro.org;
>> dillon.minfei at gmail.com; david.plowman at raspberrypi.com;
>> mark.rutland at arm.com; robh+dt at kernel.org; krzk+dt at kernel.org;
>> andi at etezian.org; alim.akhtar at samsung.com; aswani.reddy at samsung.com;
>> pankaj.dubey at samsung.com; linux-fsd at tesla.com
>> Subject: Re: [PATCH 02/20] dt-bindings: media: s5p-mfc: Convert s5p-mfc.txt
>> to new DT schema
>>
>> On 17/05/2022 14:55, Smitha T Murthy wrote:
>>> Adds DT schema for s5p-mfc in yaml format.
>>>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
> 
> Thank you for the review. 
> 

You responded after two months, I don't remember what I reviewed... Two
months periods between resends do not really help to usptream.

> 
>>> +                compatible = "samsung,mfc-v12";
>>
>> Does not look like you tested the bindings. Please run `make
>> dt_binding_check` (see Documentation/devicetree/bindings/writing-
>> schema.rst for instructions).
>> Be sure to test your bindings before sending them.
>>
> 
> I did do make dtbs and dt_binding_check using v2022.3, I will recheck post these changes.
> 
>>> +                reg = <0x12880000 0x10000>;
>>> +                clock-names = "mfc";
>>> +                interrupts = <0 137 4>;
>>
>> Use interrupt defines.
>>
> 
> When I use interrupt defines I get errors as "1.	Syntax error: This was due to interrupts field has some macro reference and needed to give absolute value.", hence I gave absolute values.

Look at other DT schema files...

Best regards,
Krzysztof