[PATCH 19/20] arm64: dts: fsd: Add MFC related DT enteries
Smitha T Murthy
smitha.t at samsung.com
Tue Jul 5 04:49:26 PDT 2022
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski at linaro.org]
> Sent: Tuesday, May 17, 2022 7:32 PM
> To: Smitha T Murthy <smitha.t at samsung.com>; linux-arm-
> kernel at lists.infradead.org; linux-media at vger.kernel.org; linux-
> kernel at vger.kernel.org; devicetree at vger.kernel.org
> Cc: m.szyprowski at samsung.com; andrzej.hajda at intel.com;
> mchehab at kernel.org; hverkuil-cisco at xs4all.nl;
> ezequiel at vanguardiasur.com.ar; jernej.skrabec at gmail.com;
> benjamin.gaignard at collabora.com; stanimir.varbanov at linaro.org;
> dillon.minfei at gmail.com; david.plowman at raspberrypi.com;
> mark.rutland at arm.com; robh+dt at kernel.org; krzk+dt at kernel.org;
> andi at etezian.org; alim.akhtar at samsung.com; aswani.reddy at samsung.com;
> pankaj.dubey at samsung.com; linux-fsd at tesla.com
> Subject: Re: [PATCH 19/20] arm64: dts: fsd: Add MFC related DT enteries
>
> On 17/05/2022 14:55, Smitha T Murthy wrote:
> > Add MFC DT node and reserve memory node for MFC usage.
> >
> > Cc: linux-fsd at tesla.com
> > Signed-off-by: Smitha T Murthy <smitha.t at samsung.com>
> > ---
> > arch/arm64/boot/dts/tesla/fsd-evb.dts | 8 ++++++++
> > arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++++++++++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > index 5af560c1b5e6..36f6b013ce99 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > @@ -37,3 +37,11 @@
> > &serial_0 {
> > status = "okay";
> > };
> > +
> > +&clock_mfc {
> > + status = "okay";
> > +};
> > +
> > +&mfc_0 {
> > + status = "okay";
> > +};
>
> Labels are ordered by name.
>
Ok, I will re-order.
> > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > index 9a652abcbcac..434ae75421d8 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > @@ -249,6 +249,18 @@
> > #clock-cells = <0>;
> > };
> >
> > + reserved-memory {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + mfc_left: region at 84000000 {
> > + compatible = "shared-dma-pool";
> > + no-map;
> > + reg = <0 0x84000000 0 0x8000000>;
> > + };
> > + };
> > +
> > soc: soc at 0 {
> > compatible = "simple-bus";
> > #address-cells = <2>;
> > @@ -748,6 +760,16 @@
> > clocks = <&fin_pll>, <&clock_imem
> IMEM_MCT_PCLK>;
> > clock-names = "fin_pll", "mct";
> > };
> > +
> > + mfc_0: mfc0 at 12880000 {
>
> Generic node names, so mfc.
>
Ok I will change.
> > + compatible = "samsung,mfc-v12";
> > + reg = <0x0 0x12880000 0x0 0x10000>;
> > + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> > + clock-names = "mfc";
> > + clocks = <&clock_mfc MFC_MFC_IPCLKPORT_ACLK>;
> > + memory-region = <&mfc_left>;
> > + status = "disabled";
>
> Why exactly this is disabled? Usually we disable nodes which needs
> resources from the boards, but this is not the case here. Unless it is?
>
I will change this in next patch series.
Regards,
Smitha
> > + };
> > };
> > };
> >
>
>
> Best regards,
> Krzysztof
More information about the linux-arm-kernel
mailing list