[PATCH v6 03/27] arm64/sysreg: Add LINKER_SCRIPT guards for sysreg.h

[Will Deacon]

On Mon, Jul 04, 2022 at 04:28:26PM +0100, Mark Brown wrote:
> On Mon, Jul 04, 2022 at 02:03:48PM +0100, Will Deacon wrote:
> 
> > Hmm, this feels quite fragile to me as we have quite a few asm/ headers
> > using the '.macro' directive and having to add LINKER_SCRIPT guards
> > because of transitive includes is going to catch people out.
> 
> Yes, for me it's a bit of a toss up if it's clearer to have the guards
> around the macros or have the users be careful about which headers they
> pull in where - both approaches have the potential for exploding on
> people.
> 
> > With your series applied on a temporary branch, it looks like the only
> > issue is the use of L1_CACHE_BYTES in hyp.lds.S and I think this is
> > because asm/cache.h is wrongly pulling things into the ASSEMBLY block.
> > The diff below fixes things for me and means we can drop the guards in
> > this patch. What do you think?
> 
> I don't really mind, your solution is equally good to me.  Do you want
> me to respin with this (I'll include it if I need to respin for some
> other reason)?

Yes, please respin without the guards and with that other whitespace issue
sorted out.

Will